Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable Datadog profiler by default when ZGC is active #4712

Merged
merged 1 commit into from
Feb 10, 2023
Merged

disable Datadog profiler by default when ZGC is active #4712

merged 1 commit into from
Feb 10, 2023

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Feb 10, 2023 •
edited
Loading

What Does This Do

Disable the Datadog profiler (revert to JFR) by default when we know ZGC is active until we can get AsyncGetCallTrace fixes into OpenJDK.

Motivation

We observed the following AsyncGetCallTrace crashes when running OpenJDK 17.0.5+8 (Zulu17.38+21-CA) with ZGC active:

Stack: [0x00007f22dbaff000,0x00007f22dbc00000],  sp=0x00007f22dbbfaef8,  free space=1007k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0x6c4438]  frame::entry_frame_is_first() const+0x8
V  [libjvm.so+0x6c368d]  forte_fill_call_trace_given_top(JavaThread*, ASGCT_CallTrace*, int, frame) [clone .isra.22]+0x7bd
V  [libjvm.so+0x6c3e8e]  AsyncGetCallTrace+0x21e
C  [libjavaProfiler2332108121502657858.so+0x1f99a]  Profiler::getJavaTraceAsync(void*, ASGCT_CallFrame*, int, StackContext*, bool*) [clone .isra.486]+0xda
C  [libjavaProfiler2332108121502657858.so+0x203f2]  Profiler::recordSample(void*, unsigned long long, int, int, Event*)+0x2c2
C  [libjavaProfiler2332108121502657858.so+0x21217]  PerfEvents::signalHandler(int, siginfo_t*, void*)+0x107
C  [libpthread.so.0+0x14420]
V  [libjvm.so+0xf3d36b]  ZBarrierSetRuntime::load_barrier_on_oop_field_preloaded(oopDesc*, oopDesc**)+0x3b


siginfo: si_signo: 11 (SIGSEGV), si_code: 128 (SI_KERNEL), si_addr: 0x0000000000000000

Stack: [0x00007f13f13f8000,0x00007f13f14f9000],  sp=0x00007f13f14f35b8,  free space=1005k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0xb51fc3]  Method::bcp_from(unsigned char*) const+0x3
V  [libjvm.so+0x6c368d]  forte_fill_call_trace_given_top(JavaThread*, ASGCT_CallTrace*, int, frame) [clone .isra.22]+0x7bd
V  [libjvm.so+0x6c3e8e]  AsyncGetCallTrace+0x21e
C  [libjavaProfiler8581851867758681629.so+0x1f99a]  Profiler::getJavaTraceAsync(void*, ASGCT_CallFrame*, int, StackContext*, bool*) [clone .isra.486]+0xda
C  [libjavaProfiler8581851867758681629.so+0x203f2]  Profiler::recordSample(void*, unsigned long long, int, int, Event*)+0x2c2
C  [libjavaProfiler8581851867758681629.so+0x21217]  PerfEvents::signalHandler(int, siginfo_t*, void*)+0x107


siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0xfffffffd00000029

Additional Notes

@richardstartin richardstartin requested a review from a team as a code owner February 10, 2023 10:21
@richardstartin richardstartin merged commit dfa0e4a into master Feb 10, 2023
@richardstartin richardstartin deleted the rgs/disable-ddprof-zgc branch February 10, 2023 13:44
@github-actions github-actions bot added this to the 1.9.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richardstartin @jbachorik